You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Touches cookie/localStorage and MPID persistence used across identity and sync; changes are typing-focused but any subtle decode/encode or null-handling mismatch could affect stored user state.
Overview
Migrates the persistence layer from JavaScript to TypeScript: persistence.js becomes persistence.ts, with the constructor and all cookie/localStorage methods typed against IPersistence / IPersistenceMinified.
persistence.interfaces.ts is tightened to match runtime behavior: nullable getPersistence, numeric first/last seen times, optional MPID/time args, encodePersistence taking a JSON string, decodePersistence returning string | null, and getDomain using Document.
Implementation edits are mostly typing and style: var → const/let, closure self → this, Dictionary casts where store/helpers are not fully typed, and toGMTString() → toUTCString() for cookie expiry. Jest persistence tests now hold an IPersistence instance instead of the untyped class.
Reviewed by Cursor Bugbot for commit 4928096. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
src/persistence.jstosrc/persistence.tswith full type annotations on all methods, parameters, and return typessrc/persistence.interfaces.tswith corrected and expanded interface definitions to support the conversiontest/jest/persistence.spec.tswith type adjustments for the converted moduleScreenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)