Skip to content

ci: remove cross-platform-tests and semantic PR/branch checks#712

Open
jamesnrokt wants to merge 1 commit into
mainfrom
ci/remove-flaky-pr-checks
Open

ci: remove cross-platform-tests and semantic PR/branch checks#712
jamesnrokt wants to merge 1 commit into
mainfrom
ci/remove-flaky-pr-checks

Conversation

@jamesnrokt
Copy link
Copy Markdown
Collaborator

Summary

Removes three checks that have been failing on nearly every recent PR (#690#711):

  • cross-platform-tests — entire workflow deleted (known broken; depends on the external mParticle/crossplatform-sdk-tests repo)
  • Check PR for semantic titlepr-title-check job removed from pull-request.yml
  • Check PR for semantic branch namepr-branch-check-name job removed from pull-request.yml

Notes

  • If any of these were listed as required checks in branch protection for main, those rules will need to be updated in repo settings so new PRs don't get stuck waiting on checks that no longer run.
  • Two other repeat-offender failures were found but not removed here:
    • Notify GChat / notify-gchat — fails on fork PRs / missing secret; it's a notification, not a gate. Worth a follow-up to add continue-on-error or remove.
    • SonarCloud Code Analysis — posted by the SonarCloud GitHub App, not a workflow file. Needs to be turned off in the SonarCloud UI / repo app settings.

Test plan

  • CI on this PR shows the three removed checks no longer appear
  • Remaining checks (unit tests, lint, instrumented tests, kit compatibility, security, trunk) still run

🤖 Generated with Claude Code

These checks have been failing on nearly every recent PR. The
cross-platform tests are known broken, and the semantic PR title /
branch name checks are no longer enforced.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jamesnrokt jamesnrokt requested a review from a team as a code owner May 27, 2026 17:35
@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Medium Risk
Fewer automated quality gates (external cross-platform tests and semantic PR/branch enforcement); branch protection must be updated or PRs can block on missing checks.

Overview
This PR stops running three CI gates that were failing on most recent PRs.

The entire .github/workflows/cross-platform-tests.yml workflow is removed, so PRs no longer check out mParticle/crossplatform-sdk-tests, run Android emulator jobs, or upload cross-platform test reports.

In .github/workflows/pull-request.yml, the reusable jobs pr-branch-check-name (semantic branch name) and pr-title-check (semantic PR title) are dropped. Other jobs in that workflow—Trunk, hardcoded secrets, instrumented/unit/lint tests, kit compatibility, dependabot automerge, GChat notify—are unchanged.

Branch protection may still list the removed check names as required; those rules need to be updated in repo settings or merges can stall waiting for checks that no longer exist.

Reviewed by Cursor Bugbot for commit 1c00575. Bugbot is set up for automated code reviews on this repo. Configure here.

@sonarqubecloud
Copy link
Copy Markdown

@BrandonStalnaker
Copy link
Copy Markdown
Contributor

Totally agree with removing the cross-platform-tests but do we no longer want standardized branch names and commit messages?

@jamesnrokt
Copy link
Copy Markdown
Collaborator Author

Totally agree with removing the cross-platform-tests but do we no longer want standardized branch names and commit messages?

For PR titles I felt that these are usually superfluous as they usually fail on the first opening PR and then can never pass so it was adding noise with ❌ on all the commits. Given we no longer use the titles for semver it seems like a fairly useless check and something we can easily edit before merge.

For branch names I don't see the value at all as our branch protection rules protect us from issues and it doesn't impact the work itself.

Wondering what your thoughts are given the above? Overall I'm happy to change it if it causes an issue, my main goal is at a glance ✅ on commits

@nickolas-dimitrakas
Copy link
Copy Markdown

Totally agree with removing the cross-platform-tests but do we no longer want standardized branch names and commit messages?

For PR titles I felt that these are usually superfluous as they usually fail on the first opening PR and then can never pass so it was adding noise with ❌ on all the commits. Given we no longer use the titles for semver it seems like a fairly useless check and something we can easily edit before merge.

For branch names I don't see the value at all as our branch protection rules protect us from issues and it doesn't impact the work itself.

Wondering what your thoughts are given the above? Overall I'm happy to change it if it causes an issue, my main goal is at a glance ✅ on commits

I second the bit about not being able to correct the PR titles for the ✅. It was tedious to have to open a new PR with a proper branch name. No problem with any of the other jobs that were removed either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants