Skip to content

feat: Add active_time_on_site_ms and partner_identities to DTO#135

Merged
rmi22186 merged 1 commit into
masterfrom
feat/add-tos
May 29, 2026
Merged

feat: Add active_time_on_site_ms and partner_identities to DTO#135
rmi22186 merged 1 commit into
masterfrom
feat/add-tos

Conversation

@rmi22186
Copy link
Copy Markdown
Member

Summary

Re-doing #131 because it was never released and has diverged from master.

@rmi22186 rmi22186 requested a review from a team as a code owner May 29, 2026 18:23
@cursor
Copy link
Copy Markdown

cursor Bot commented May 29, 2026

PR Summary

Low Risk
Backward-compatible optional TypeScript fields and test-only fixture updates; no runtime logic or security-sensitive behavior changes in this diff.

Overview
Extends the events package TypeScript DTOs with two optional fields aligned to the server event schema.

Batch gains partner_identities, a string map for multiple partner identity key/value pairs (alongside the existing singular partner_identity string). CommonEventData gains active_time_on_site_ms, so any event type that extends common event data can carry active time on site in milliseconds.

Spec fixtures in packages/events/tests/index.spec.ts are updated to exercise both fields on representative Batch and event payloads.

Reviewed by Cursor Bugbot for commit 337a87e. Bugbot is set up for automated code reviews on this repo. Configure here.

@rmi22186 rmi22186 requested a review from khushi1033 May 29, 2026 18:25
@rmi22186 rmi22186 merged commit c724b7f into master May 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants