Update examples for M5Unified and fix UHF memory access - #19
Open
LuoIsHere wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17.
This PR updates the UHF RFID examples to support the latest version of M5Unified and fixes several issues in the examples and library implementation.
Changes
0x04to0x03, which is the User Memory bank defined by the UHF RFID protocol.saargument inreadCard()to the start-address fields of the command frame.log()function so that the provided message is printed to the serial port instead of always printing a fixed string.Details
The examples previously passed
0x04as the memory bank when reading from or writing to User Memory. According to the UHF RFID protocol, User Memory is identified by0x03.Additionally, although
readCard()accepts ansastart-address argument, the argument was not written to the command buffer. This caused read operations to continue using the default start address of zero.The
log()helper also ignored its input when writing to the serial port and always printed the same fixed message.