Fixed issues returning datetime value from DateTimePickerDialog#63
Open
paulcappadona wants to merge 1 commit intom3uzz:masterfrom
Open
Fixed issues returning datetime value from DateTimePickerDialog#63paulcappadona wants to merge 1 commit intom3uzz:masterfrom
paulcappadona wants to merge 1 commit intom3uzz:masterfrom
Conversation
…Dialog, which was causing parse errors and incorrect values being returning the the widget onChangedHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case we had a PM time, sValue would only be set with the 12 hour format value (ie 14:00 would be 2:00)
The incorrect value could also be returned to the widget onChangedHandler as a result, with results passed back as yyyy-MM-dd hh:mm. This was resulting in incorrect values for any PM time (and 12AM).