Lower minimum Node version to 22.16#154
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by kimi-k2.6 · Input: 371.9K · Output: 17K · Cached: 1.3M |
Contributor
There was a problem hiding this comment.
Pull request overview
Lowers Codegraph’s minimum supported Node.js runtime from 24.10 to 22.16, updating CI, TypeScript Node typings, and user-facing installation guidance accordingly, while keeping required node:sqlite statement-metadata APIs usable via a local type bridge.
Changes:
- Drop the
engines.nodefloor to>=22.16and align@types/nodeto the Node 22.16 line. - Update CI and documentation to reflect the new minimum Node version.
- Add a large implementation plan doc for IDE-style agent navigation/refactor capabilities.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/package-metadata.test.ts | Updates the asserted Node engine floor to >=22.16 and clarifies the SQLite API requirement wording. |
| src/sqlite-driver.ts | Introduces a narrow NodeSqliteStatement bridge and updates statement handling to match Node 22.16 SQLite metadata APIs. |
| README.md | Updates the “Try it” Node.js requirement to 22.16+. |
| package.json | Lowers engines.node and pins @types/node to ~22.16.0. |
| package-lock.json | Updates lockfile entries for Node typings and transitive dependencies. |
| docs/plans/2026-07-12-ide-style-agent-navigation-refactor.md | Adds a detailed design/implementation plan document. |
| docs/installation.md | Updates the documented Node.js requirement to 22.16+. |
| codegraph-skill/codegraph/SKILL.md | Updates the bundled skill installation requirement to Node.js 22.16+. |
| .github/workflows/on-demand-ci.yml | Runs CI on Node 22.16.0 to validate the new minimum runtime. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
132
to
134
| prepare(sql: string): SqliteStatement { | ||
| return new SqliteStatement(this.db.prepare(sql)); | ||
| return new SqliteStatement(this.db.prepare(sql) as NodeSqliteStatement); | ||
| } |
Comment on lines
19
to
23
| - name: Setup Node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 24.10.0 | ||
| node-version: 22.16.0 | ||
| cache: npm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why Node 22.16
Node 20 does not provide
node:sqlite. Node 22.16 is the first Node 22 release containing bothStatementSync.setReturnArrays()andStatementSync.columns(), which Codegraph's SQLite layer requires.Verification
npx --yes --package=node@22.16.0 -- npm run buildnpx --yes node@22.16.0 ./node_modules/vitest/vitest.mjs run tests/sqlite.test.ts tests/package-metadata.test.ts(58 passed)npm run test:integration(130 passed)orient --root . --budget small --jsonsmoke testgit diff --cached --checkNode 22.16 emits its upstream experimental warning when
node:sqliteis loaded; behavior is otherwise covered by the focused SQLite suite.