[WRONG BRANCH] fix(cursor): prevent cross-account Max Mode capability leakage - #401
[WRONG BRANCH] fix(cursor): prevent cross-account Max Mode capability leakage#401luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0c47c363a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const ultraRequested = parsed.ultra || reasoning?.toLowerCase() === "ultra"; | ||
| const evidence = liveMaxModeIds ?? liveCursorMaxModeBases; | ||
| const maxModeArmed = capability.maxModeVerified === true || evidence.has(parsed.baseId); | ||
| const maxModeArmed = capability.maxModeVerified === true || liveMaxModeIds?.has(parsed.baseId) === true; |
There was a problem hiding this comment.
For an account whose GetUsableModels response marks an otherwise-unverified model as Max-Mode capable, Ultra requests now silently omit the maxMode wire flag. This resolver's new argument is never supplied by production code: src/adapters/cursor/request-builder.ts:215 still calls it with only two arguments, while this commit also discards liveResult.maxModeModels in provider-fetch.ts, so only the statically verified kimi-k3 can use Max Mode. Preserve the evidence in a provider/credential-scoped store, pass the selected route's set into request construction, and add a focused discovery-to-request regression test.
AGENTS.md reference: AGENTS.md:L336-L339
Useful? React with 👍 / 👎.
1 participant
Motivation
GetUsableModelsmax-mode evidence into a process-global singleton, letting one provider/account's results affect requests routed to other providers or accounts.Description
liveCursorMaxModeBasessingleton and itsrecordLiveCursorMaxModeModelsmutation from the catalog code.src/codex/catalog/provider-fetch.tsso provider fetch remains account-scoped and only caches the discovered roster.resolveCursorSelection; otherwise, only staticmaxModeVerifiedcapability can arm Max Mode (src/adapters/cursor/catalog.ts).tests/cursor-umbrella-rows.test.ts).Testing
bun test tests/cursor-umbrella-rows.test.ts tests/cursor-catalog.test.ts tests/cursor-ultra-mode.test.ts, all tests in those files passed.bun run test, which completed with tests passing in this environment (no new failures observed).bun run typecheckpassed andbun run privacy:scanpassed.bun run test:changedcould not run because this checkout has nodev/origin/dev/upstream/devcomparison ref; this is an environment limitation, not a code failure.Codex Task