[WRONG BRANCH] fix(windows): refresh startup ownership listing - #395
[WRONG BRANCH] fix(windows): refresh startup ownership listing#395luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47fa9d72cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // #2923: retain a successful fallback listing only within the first startup | ||
| // ownership decision. A targeted query's bytes are not a Task Scheduler state | ||
| // generation, so the later race-sensitive decision must take a fresh listing. | ||
| // Runtime ownership retries below intentionally omit this startup-local memo too. |
There was a problem hiding this comment.
Keep startup within the service health window
On the documented localized Windows path where the targeted /xml response requires a full listing, this now runs two sequential listings before the listener binds. The measured host recorded in structure/04_transports-and-sidecars.md:22-34 takes 12.3 seconds per listing, so startup takes roughly 25 seconds, while confirmServiceServing gives ocx service install, start, and repair only 20 seconds (src/service.ts:655,687,708-720). Those commands will therefore report failure and exit 1 even though the service is still starting; the update path explicitly interprets that exit as reason to fall back to a direct start (src/service.ts:699-702). Preserve the fresh second ownership evidence, but adjust the corresponding service readiness budget or otherwise avoid exceeding it.
AGENTS.md reference: src/AGENTS.md:L10-L11
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
startupWindowsTaskListingCachefrom the laterinspectStartupOwnershipcall insrc/server/index.tsand update the explanatory comment.tests/codex-service-manager-probe-hardening.test.tsthat models a task being registered after the second localized targeted/xmlsnapshot and asserts the code performs a fresh full listing (two listings) and returns the saferunknownverdict on the second inspection.Testing
bun test tests/codex-service-manager-probe-hardening.test.ts --timeout 30000, which passed the modified probe hardening tests (all tests in that file passed).bun run typecheck, which succeeded.bun run privacy:scan, which succeeded.Codex Task