[WRONG BRANCH] fix(service): keep slow task listing off request path - #390
[WRONG BRANCH] fix(service): keep slow task listing off request path#390luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30ecbbfc7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (queried.status !== null && SCHTASKS_TASK_NOT_FOUND_EN.test(queryText)) { | ||
| return { registered: "absent", registeredXml: "" }; | ||
| } | ||
| if (deps.skipWindowsTaskListing) { |
There was a problem hiding this comment.
When a demand-driven ownership retry reaches Windows after a targeted schtasks query fails with a non-English or otherwise inconclusive response, this guard never fires: inspectServiceManagerInstallation reconstructs the argument to inspectWindows at lines 993–1000 but omits deps.skipWindowsTaskListing. Consequently the request path still executes the full scheduled-task listing and can block Bun's event loop for its 20-second timeout. Add the flag to inspectWindows's dependency type and forward it from the Windows dispatch.
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
1 participant
Motivation
/query /fo CSV /nhlisting so hosts that need locale-neutral evidence can still complete startup inspection.Description
skipWindowsTaskListingprobe flag toProbeDepsand thread it through the ownership inspection API so callers can opt out of the slow full/queryenumeration.probeWindowsTaskRegistrationwhenskipWindowsTaskListingis set so demand-driven retries returnunknownwithout invoking/fo CSV /nh.inspectStartupOwnershipto accept and forward the new flag, and ensure request-driven recovery probes call the inspector withskipWindowsTaskListing=truewhile startup inspections keep the full listing enabled./fofull listing and to verify the startup vs request-path behavior in the native startup tests.Testing
bun run typecheckand it succeeded.bun run privacy:scanand it succeeded.git diff --check/ local repository checks and they were clean for the change set.tests/codex-service-manager-probe-hardening.test.tsandtests/native-profile-startup.test.ts, but their execution in the container failed early due to the environment Bun runtime importingnode:zlib(missingzstdDecompressSyncexport), so those focused tests could not complete in this environment; the added test assertions are included and expected to pass under CI/Bun environments that meet the repository runtime expectations.bun run testwas exercised with the repository's runner but was not accepted as a clean signal here because the run surfaced unrelated endpoint/auth failures in this environment; the change set itself is small and covered by the focused tests added.Codex Task