[WRONG BRANCH] fix(codex): hand off affinity in refresh flight - #389
[WRONG BRANCH] fix(codex): hand off affinity in refresh flight#389luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
registerCodexRefreshGenerationHandoffand a process-localrefreshGenerationHandoffsset tosrc/codex/account-store.tsto record callbacks that must run when a refresh advances a credential generation.G -> G+1commit advances process-local state before any waiter observes the result.handOffThreadAffinityGeneration) with the flight, and extend thecancel-ownerregression test to assert the detached flight performs one G→G+1 handoff intests/codex-account-store.test.ts.Testing
bun test tests/codex-account-store.test.ts, which passed (42 tests, 0 failures).node_modules/bun/bin/bun.exe test tests/codex-routing.test.ts) and observed they pass in that environment, while the system Bun (older) lacked anode:zlibexport required by the suite.bun run typecheckandbun run privacy:scan, both of which completed successfully.Codex Task