[WRONG BRANCH] fix(ollama): bound pending native tool calls - #385
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
NATIVE_TOOL_NAME_MAX_BYTES = 1024,NATIVE_MAX_PENDING_TOOL_CALLS = 128, and a smallNATIVE_TOOL_CALL_BOOKKEEPING_BYTESoverhead, and enforce them duringnativeMessageEvents. (file:src/adapters/ollama-native.ts)NativeStreamToolCall, and fail admission when the budget or per-call/pending-count bounds are exceeded. (file:src/adapters/ollama-native.ts)tests/ollama-native-parser.test.ts)Testing
bun test tests/ollama-native-parser.test.tsand the modified suite passed (29tests,0failures).bun run typecheckand it succeeded.bun run testfor broader confidence; the run surfaced unrelated pre-existing failures in Lab automation / API auth and a long-running chat-completions timeout, so only the focused Ollama-native tests and typecheck are relied on for this change.Codex Task