Skip to content

[WRONG BRANCH] fix(responses): scope compact handoff cache to authenticated admission principal - #384

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-compact-handoff-vulnerability
Draft

[WRONG BRANCH] fix(responses): scope compact handoff cache to authenticated admission principal#384
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-compact-handoff-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent cross-principal rerouting where a process-global compact-handoff cache keyed only by caller-supplied lane headers could cause one authenticated client to influence another client's compact request routing.
  • Ensure fallback reroutes only apply within the same authenticated admission principal and do not leak a victim's compact body or quota to an attacker-visible provider.

Description

  • Add compactHandoffRouteKey(req, admission) that composes the resolved DataPlaneAdmission principal with the session lane to key handoff state, and treat loopback/admission-less requests as ineligible.
  • Replace the previous process-global lane-only helpers with rememberCompactHandoffRoute, forgetCompactHandoffRoute, and compactHandoffRoute that accept the admission and use the namespaced key.
  • Wire the new admission-scoped key into handleResponsesCompact so remembered routes are stored, retrieved, and cleared only for the same authenticated principal.
  • Update the focused regression test (tests/responses-compaction-routing.test.ts) to assert same-principal handoff still works while a different configured principal and a loopback caller cannot consume the cached route.

Testing

  • Ran bun test tests/responses-compaction-routing.test.ts which passed (focused compaction-routing suite).
  • Ran bun run typecheck which passed.
  • Ran bun run privacy:scan which passed.
  • Executed the full test run during validation; the focused compaction tests passed and the change did not affect the compact routing behaviors, while one unrelated full-suite run previously observed a timeout in a different test (environment-dependent) and is not related to this change.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T00:59:38.302715Z 036ef81 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b0818d14-73ed-45c3-8a1e-5c28f5302450


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 31, 2026
@github-actions github-actions Bot changed the title fix(responses): scope compact handoff cache to authenticated admission principal [WRONG BRANCH] fix(responses): scope compact handoff cache to authenticated admission principal Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 31, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant