[WRONG BRANCH] fix(responses): scope compact handoff cache to authenticated admission principal - #384
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
compactHandoffRouteKey(req, admission)that composes the resolvedDataPlaneAdmissionprincipal with the session lane to key handoff state, and treat loopback/admission-less requests as ineligible.rememberCompactHandoffRoute,forgetCompactHandoffRoute, andcompactHandoffRoutethat accept the admission and use the namespaced key.handleResponsesCompactso remembered routes are stored, retrieved, and cleared only for the same authenticated principal.tests/responses-compaction-routing.test.ts) to assert same-principal handoff still works while a different configured principal and a loopback caller cannot consume the cached route.Testing
bun test tests/responses-compaction-routing.test.tswhich passed (focused compaction-routing suite).bun run typecheckwhich passed.bun run privacy:scanwhich passed.Codex Task