[WRONG BRANCH] fix(claude): avoid blocking registry probes by async probe + cache - #381
[WRONG BRANCH] fix(claude): avoid blocking registry probes by async probe + cache#381luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
/api/claude-desktop/statushandler from synchronously spawningreg.exeon every request and blocking the server event loop on Windows.Description
probeClaudeDesktopPolicyAsync(usesexecFile) that preserves the same timeout, decoding, and probe semantics as the synchronous runner.createCachedClaudeDesktopPolicyProbeandgetCachedClaudeDesktopPolicywith a 30s TTL to limit registry refreshes and single-flight concurrent refreshes.GET /api/claude-desktop/statusto await the cached asynchronous probe in production while keeping the existing dependency seam (deps.probeClaudeDesktopPolicy) for tests.Testing
bun test tests/claude-desktop-policy.test.tsand all tests passed (7/7).bun run typecheckand the typecheck passed.bun run privacy:scanand the privacy scan passed.bun run test); the focused tests for this change passed, while unrelated full-suite failures/timeouts were observed and are unrelated to this change.Codex Task