This repository was archived by the owner on May 27, 2019. It is now read-only.
Separate Ubuntu specifics into OS-specific case statements, add prerequisites to work with Centos 6#4
Open
evilensky wants to merge 6 commits intolucaspiller:masterfrom
Open
Separate Ubuntu specifics into OS-specific case statements, add prerequisites to work with Centos 6#4evilensky wants to merge 6 commits intolucaspiller:masterfrom
evilensky wants to merge 6 commits intolucaspiller:masterfrom
Conversation
Author
|
Also sets some Facter facts that are useful to me in the long run (I plan to query these Facts in Apache/Passenger template .conf files). |
Owner
|
Sorry I've just noticed this pull request :) It looks good however I'm going to change a few minor things before I merge it in. Just FYI, me nitpicking: a) Coding style (trailing new lines, trailing commas in arrays, indentation) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Centos 6 and separates prerequisites into OS-specific case statements. Thank you!