fix: add authentication check in server.js (CWE-306) - #461
Merged
luc-github merged 1 commit intoSep 26, 2026
Merged
luc-github merged 1 commit into
luc-github merged 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Express server exposes /config and /command endpoints without any authentication middleware. The /command endpoint accepts arbitrary G-code commands via the 'cmd' query parameter and passes them directly to commandsQuery(). The /config endpoint exposes device configuration. Neither endpoint validates that the request is authenticated before processing. This was found by static analysis at
config/server.js:102. I have not demonstrated an exploit against your deployment, so please judge it against your own threat model.Reference: CWE-306
What changed
config/server.jsVerification
No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.
Automated security fix by OrbisAI Security