DM-49364: Switch LATISS/bestEffortIsr to IsrTaskLSST#167
DM-49364: Switch LATISS/bestEffortIsr to IsrTaskLSST#167mfisherlevine wants to merge 13 commits intomainfrom
Conversation
czwa
left a comment
czwa
left a comment
There was a problem hiding this comment.
I'm not going to make the change request mandatory, but unless there's a compelling reason not to doApplyGains=True, I think that will improve things.
config/quickLookIsr.py
Outdated
| config.brighterFatterMaxIter = 2 # Uncomment this to remove test warning | ||
| config.doDeferredCharge = False # no calib for this yet | ||
| config.doBootstrap = False | ||
| config.doApplyGains = False |
There was a problem hiding this comment.
Unless you expect to never have a PTC, I would strongly suggest this be set to doApplyGains=True. The new ISR defaults largely assume that everything has had gains applied so units are in electrons. We also should have CTI calibrations in the next set, but that correction is far less likely to have visual impact on the images than doApplyGains (which should help remove amp offsets).
There was a problem hiding this comment.
Oh, for sure - totally agreed! This is all ancient stuff that used to be necessary years ago, I'm up for any/all changes like that 👍.
mfisherlevine
force-pushed
the
tickets/DM-49364
branch
from
0d51cfb to
33a4d90
Compare
Replace detectObjectsInExp with direct detection using Threshold.VALUE and np.std() to avoid STDEVCLIP returning 0 for some guider images. Add starMaskThreshold parameter to exclude bright pixels when computing background standard deviation.
Add a uniform [0, 1) random dither per stamp before computing the median coadd. This breaks integer quantization that causes the pixel distribution to be so narrow that STDEVCLIP returns 0 on some guider images. Fix suggested by Robert Lupton. (DM-54263)
Replace the manual sigma68-only background estimation with STDEVCLIP from lsst.afw.math, falling back to sigma68 if STDEVCLIP returns 0. The dithered coadds (previous commit) prevent STDEVCLIP from failing, but the fallback provides a safety net. Also adds a configurable nPixMin parameter for footprint detection. (DM-54263)
Address review feedback from Merlin: use explicit assertion instead of mypy ignore comment. (DM-54263)
3 participants
No description provided.