fix: reasoning_effort "max" silently became "medium" for Claude#707
Open
Fwind43 wants to merge 1 commit into
Open
fix: reasoning_effort "max" silently became "medium" for Claude#707Fwind43 wants to merge 1 commit into
Fwind43 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
'max': 'max'to the Claudereasoning_effortmapping in_apply_claude_thinking(llmcore.py).Why
reasoning_effortacceptsmaxat config level (_enumincludes it), but the Claude mapping only knewlow/medium/high/xhigh. Settingmaxhit the WARN branch and dropped the field entirely; then thefake_cc_system_promptpath injected the default{"effort": "medium"}— so a user who configuredmaxsilently sentmediumto the API.xhigh -> maxstill works unchanged;maxis now a direct alias.Testing
py_compilepasses._apply_claude_thinkingon a stub:max -> max,xhigh -> max,medium -> medium,none -> WARN/ignored(unchanged).