Skip to content

fix: reasoning_effort "max" silently became "medium" for Claude#707

Open
Fwind43 wants to merge 1 commit into
lsdefine:mainfrom
Fwind43:fix/claude-effort-max
Open

fix: reasoning_effort "max" silently became "medium" for Claude#707
Fwind43 wants to merge 1 commit into
lsdefine:mainfrom
Fwind43:fix/claude-effort-max

Conversation

@Fwind43

@Fwind43 Fwind43 commented Jul 26, 2026

Copy link
Copy Markdown

What

Add 'max': 'max' to the Claude reasoning_effort mapping in _apply_claude_thinking (llmcore.py).

Why

reasoning_effort accepts max at config level (_enum includes it), but the Claude mapping only knew low/medium/high/xhigh. Setting max hit the WARN branch and dropped the field entirely; then the fake_cc_system_prompt path injected the default {"effort": "medium"} — so a user who configured max silently sent medium to the API.

xhigh -> max still works unchanged; max is now a direct alias.

Testing

  • py_compile passes.
  • Unit-exercised _apply_claude_thinking on a stub: max -> max, xhigh -> max, medium -> medium, none -> WARN/ignored (unchanged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant