Raise JaCoCo thresholds to 95% instructions and 90% branches - #26
Merged
Merged
Conversation
The check rule only enforced 90% instruction coverage. With the reported scope now covering everything but the GUI shell at 99.3% instructions and 97.1% branches, raise the instruction minimum to 0.95 and add a branch minimum of 0.90 so branch coverage is enforced too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last PR of the coverage plan (phase 4). Pom only.
COVEREDRATIOminimum raised from 0.90 to 0.95BRANCHCOVEREDRATIOrule at 0.90, since branches were not enforced beforeCurrent coverage is 99.3% instructions and 97.1% branches, so both rules pass with margin. A PR that drops either below the threshold now fails
./mvnw verifyon the PR build.I did not enable
fail-on-coverage-decreasein the badge generator step. It only runs on master pushes, so it would fail the build after the merge rather than block it, and the JaCoCo rule already fails the PR build.🤖 Generated with Claude Code