[i2c, dv] I2C V1 sign-off#616
Conversation
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
2090013 to
0541ff3
Compare
KinzaQamar
requested review from
elliotb-lowrisc,
marnovandermaas and
martin-velay
| [i2c_bind.sv]: ../../hw/vendor/lowrisc_ip/ip/i2c/dv/sva/i2c_bind.sv | ||
| [tb.sv]: ../../hw/vendor/lowrisc_ip/ip/i2c/dv/tb/tb.sv | ||
| [I2C DV document]: ../../hw/vendor/lowrisc_ip/ip/i2c/dv/README.md | ||
| [I2C testplan]: ../../hw/vendor/lowrisc_ip/ip/i2c/data/i2c_testplan.hjson |
There was a problem hiding this comment.
Duplicated link (already defined at line 80)
|
|
||
| *Checklist to be defined — see [stages.md][verification stages].* | ||
|
|
||
| [COSMIC reports dashboard]: https://private.reports.lowrisc.org |
There was a problem hiding this comment.
That's our internal link, only accessible by us. You should change it into:
| [COSMIC reports dashboard]: https://private.reports.lowrisc.org | |
| [COSMIC reports dashboard]: https://dashboard.reports.lowrisc.org/cosmic/mocha/dashboard.html |
There was a problem hiding this comment.
This links gives a report on 29/4. Just a summary of percentage and not what is passing and failing? Do we have a proper public dashboard?
There was a problem hiding this comment.
Yes I have shared this issue already with @machshev, he's on holidays but I guess he'll take a look later. If you prefer you can say that you've checked on our private regressions and provide the date and share the Git hash mentioned in there, as such lowRISC fellows can cross-check at least. But please keep the public dashboard link as done in the template
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
0541ff3 to
eddb068
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Some initial nits from my end.
| * 7-bit target address | ||
| * all the mandatory features listed for controllers in [Table 2: I2C specification Rev 6][] | ||
| * multi-controller features such as bus arbitration and controller-controller clock synchronization | ||
| * clock stretching in both controller and target modes |
There was a problem hiding this comment.
| * clock stretching in both controller and target modes | |
| * clock stretching in both controller and target modes. |
|
|
||
| The I2C block is imported from OpenTitan. The documentation is located [here][block doc]. | ||
| The I2C block can be programmed in both controller and target modes. It supports: | ||
| * speeds for standard, fast and fast plus modes. |
There was a problem hiding this comment.
| * speeds for standard, fast and fast plus modes. | |
| * speeds for standard, fast and fast plus modes |
| ### D1 | ||
|
|
||
| The sign-off checklist items are described in the [D1 design sign-off checklist][D1 checklist]. | ||
| This sign-off is based on commit [`1234def`][d1-commit] (nightly yyyy-mm-dd). |
There was a problem hiding this comment.
This placeholder looks weird. Maybe we can say that D1 sign-off is not started yet.
There was a problem hiding this comment.
I think Kinza did that because of what I've done for the GPIO. To me it was looking more logic to keep the template placeholders, but since you are 2 feeling the other way, I'll change it in my PR too
| |---------------|------------------------------------|--------|------------------| | ||
| | Documentation | DV_DOC_DRAFT_COMPLETED | Done | [I2C DV document][] describes the goals, testbench architecture, stimulus, coverage and checking strategy | | ||
| | Documentation | TESTPLAN_COMPLETED | Done | [I2C testplan][] defines the V1 smoke test and post-V1 functional, error, performance and stress testpoints | | ||
| | Testbench | TB_TOP_CREATED | Done | [tb.sv][]; instantiates clock and reset, tilelink, I2C, and interrupt interfaces along with I2C DUT | |
There was a problem hiding this comment.
| | Testbench | TB_TOP_CREATED | Done | [tb.sv][]; instantiates clock and reset, tilelink, I2C, and interrupt interfaces along with I2C DUT | | |
| | Testbench | TB_TOP_CREATED | Done | [tb.sv][] instantiates clock and reset, tilelink, I2C, and interrupt interfaces along with I2C DUT | |
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
eddb068 to
53e29e1
Compare
3 participants
No description provided.