[rtl] Switch to ratified bitmanip extensions - #2459
Conversation
afac420 to
6062faa
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Initial comments from me. Do you think it is worth squashing the commits that just remove things? I think it may be excessive to have 9 separate commits for removing instructions.
I have them as individual commits to help people review the changes. I would have squashed all into one after the review process. What do you think? |
SamuelRiedel
left a comment
SamuelRiedel
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the bitmanip @thommythomaso. I did a quite thorough review, but most of it should be easy to fix.
The only thing that is left is that we should update RISC-V DV to also support the latest ratified extensions. I saw that the ratified B extensions are supported already, but for the scalar crypto ones, we currently simply enable the Zbp still, right? I think this is good enough for now, but we should create an issue documenting the current state, like which instructions are emitted by riscv-dv and which aren't and what we would ideally want to then clean up the DV in a second step at least.
e3c3ce9 to
753e7ac
Compare
This PR removes the unratified bitmanip extensions from Ibex and switches to the ratified set. We remove `Xzbe0p93`, `Xzbf0p93`, `Xzbr0p93`, `Xzbt0p93`, and `Xzbe0p93`, replacing them with `Zbkb` and `Zbkx`. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
753e7ac to
5a51b6c
Compare
3 participants
This PR switches the RTL of Ibex from our currently unratified bitmanip extension to the officially ratified extensions.
An overview of the changes can be found here.
This PR only introduces the RTL changes and ensures the CI tests pass. Certain scalar crypto extensions are not yet fully verified; see #2468.