Remove srecord and use objcopy instead#2062
Conversation
|
CI fails because the version of riscv-compliance-suit that the CI uses also has srecord. I think that's not the case with its current version but moving to it would be bigger task. I'll put back the srecord requirement but edit it to say it's for the riscv-compliance test suit. Rest is up to you 😄 |
Now that objcopy have support for `--verilog-data-width`, we don't need srecord anymore. Only keep it for riscv-compliance testing reasons. Signed-off-by: Canberk <canberk.topal@riverlane.com>
e9bf006 to
c548445
Compare
|
I just checked, and the I'm reasonably sure that this is ancient enough that we can just depend on it, but I couldn't figure out what base versions we use in our documentation. @GregAC, any concerns, or should we just merge? |
I believe here we recommend either using the pre-built lowRISC toolchain (binutils v2.35) or building the riscv-gnu-toolchain from source (binutils ~v2.40). Note that this fix landed in binutils v2.40 for an issue with I'm not sure whether that issue applies here or whether 2.40 fixes it, but maybe we should update the version our toolchain ships. |
Now that
objcopyhave support for--verilog-data-width, we don't needsrecordanymore. To be fair, the current setup already supports pointing just to an.elffile but it's still nice to have the.vmem.