Repository navigation
fix(rust): preserve fragmented updates and isolate timeout ownership - #67
Open
petralithic wants to merge 1 commit into
Open
petralithic wants to merge 1 commit into
petralithic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragmented updates can lose received data or fail to complete when an empty fragment arrives, a header repeats, or an old timeout fires after the same batch key is reused. A sender-declared total can also trigger an excessive output reservation.
Track arrival separately from payload length, retain the existing batch and deadline on duplicate headers, and cancel completed timers while checking entry ownership. Size the assembled buffer from actual received bytes. Wire encoding and acceptance of payloads whose declared size is smaller than their actual size remain unchanged.
The Rust WebSocket client already uses Tokio. Timeout cancellation uses its existing
syncfeature. The patch enablestest-utilonly for tests so they can advance a simulated clock. Production builds use the same Tokio features as before.