Skip to content

refactor(extensions): one owner for the connector token shape #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 4 commits into from
Oct 1, 2026
+404 −2
Merged

refactor(extensions): one owner for the connector token shape #5361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1826bce
refactor(extensions): ask the runtime for the connector token shape
karenchuu Sep 30, 2026
c1cef09
test(architecture): guard the single connector token shape
karenchuu Sep 30, 2026
57e78cc
test(architecture): correct the counted imports named in the guard's …
karenchuu Sep 30, 2026
3c12cc3
Merge branch 'main' into codex/connector-token-shape-owner
huangruiteng Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion loopx/extensions/external_connector_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from .external_connector_runtime import (
CONNECTOR_SCHEMA_VERSION,
EVENT_SCHEMA_VERSION,
SAFE_TOKEN_PATTERN,
ExternalConnectorCapability,
ExternalResponsePolicy,
ExternalSourceKind,
Expand All @@ -38,7 +39,6 @@
)
PROVIDER_PAGE_SCHEMA_VERSION = "agent_external_connector_provider_page_v0"

SAFE_TOKEN_PATTERN = re.compile(r"[A-Za-z0-9][A-Za-z0-9._:-]{0,199}")
SAFE_SCOPE_PATTERN = re.compile(r"[A-Za-z0-9][A-Za-z0-9._:/-]{0,199}")

ProviderPageReader = Callable[[Mapping[str, Any], str | None, int], Mapping[str, Any]]
Expand Down
2 changes: 1 addition & 1 deletion loopx/extensions/lark/document_comment_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from urllib.parse import urlsplit

from ...control_plane.content_digest import ENVELOPED_SHA256_PATTERN
from ..external_connector_runtime import SAFE_TOKEN_PATTERN
from ...file_lock import exclusive_file_lock
from ..external_connector_provider import (
build_external_connector_permission_requirement,
Expand All @@ -45,7 +46,6 @@
LARK_DOCUMENT_COMMENT_REPLY_STORE_SCHEMA = "lark_document_comment_reply_store_v0"
LARK_DOCUMENT_COMMENT_REPAIR_URL = "https://open.larksuite.com/app"

SAFE_TOKEN_PATTERN = re.compile(r"[A-Za-z0-9][A-Za-z0-9._:-]{0,199}")
SAFE_PROFILE_PATTERN = re.compile(r"[A-Za-z0-9][A-Za-z0-9_.-]{0,99}")
IDEMPOTENCY_KEY_PATTERN = ENVELOPED_SHA256_PATTERN
CURSOR_PREFIX = "lark-comment-v0."
Expand Down
Loading
Loading