fix(exporter): remove unused HTML DataJSON dead code - #22
Closed
MrBeldum wants to merge 1 commit into
Closed
Conversation
DataJSON was marshaled from iterations but never referenced in the template. Drop the field and add export regression coverage. Fixes loop-eng#14
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html.gocomputedDataJSONviajson.Marshalon iterations, but the HTML template never referenced it. That was pure dead work on every export.DataJSONfield and marshal stepencoding/jsonimportFixes #14
Test plan
go test ./internal/exporter/ -count=1