Adding DATE_8601 to the list of default Grok patterns#124
Open
berglh wants to merge 2 commits intologstash-plugins:mainfrom
Open
Adding DATE_8601 to the list of default Grok patterns#124berglh wants to merge 2 commits intologstash-plugins:mainfrom
berglh wants to merge 2 commits intologstash-plugins:mainfrom
Conversation
…ot actually implemented
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Woops, wrong way around
|
This would address #67 and #112. I'm not sure if it resolves it, as .. wouldn't the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On line 65 of this pattern file is the following comment:
It turns out the format in this comment isn't actually covered with YYYY MM DD with any other delimiter other than hyphens such as in
TIMESTAMP_ISO8601.There are a lot of log files that contain
YYYY/MM/DD, not just the officialISO8601time stampYYYY-?MM-?DD.I made the
DATE_8601pattern and suffixed it to theDATEpattern so whenDATESTAMPis use, it covers all three common use formats. TheYYYY MM DDis in used in China, Korea, Taiwan, Hungary, Iran, Japan, Lithuania due toISO 8601. Also plenty of other countries use this format. I think for completeness of the basic date patterns it has a place here with all three common delimiters.I think perhaps
DATE_8601is the wrong name for this pattern. Using slashes or dot delimiters is not an official 8601 format according to ISO8601.I'm suspecting we should change this, but I don't know what a suitable suffix would be as it's hard to aggregate the aforementioned countries into a region code like the other date patterns in the file.