Skip to content

Fix Quote editing, historical dates, and iPad controls - #98

Merged
tiensonqin merged 1 commit into
mainfrom
fix/native-editor-dates-ipad
Oct 26, 2026
Merged

tiensonqin merged 1 commit into
mainfrom
fix/native-editor-dates-ipad

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Typing > now creates a Quote block, multi-paragraph Quote pastes stay in one block, and Code/Calculator editing has a software-keyboard action for creating a new block. Date editors support direct calendar-date input, including historical dates, and full date references in text properties create or reuse Journal pages.

  • Keep shortcut, paste, block creation, reference resolution, and date validation in the shared OCaml core; preserve literal Code/Math text and partial year/month references.
  • Flush pending Android editor input before toolbar actions so newly typed text is preserved.
  • Synchronize Android calendar selection with typed dates, allow years 1–9999, and use Gregorian labels consistently for historical dates.
  • Constrain long graph names so the iPad Settings button remains visible; use the root keyboard layout guide to keep the bottom toolbar independent of floating keyboards.

Related to logseq/db-test#1473.

Validation:

  • dune build @shared/native/runtest: 1192 tests passed, including offline restart and synchronization of text-property Journal references.
  • iOS Release simulator build and native checks for long graph names, docked/dismissed keyboards, empty/populated search dismissal, search-result editor toolbar, and Code editor presentation.
  • Android debug and instrumentation builds; native Calculator return/toolbar input checks and historical date/property checks.

Floating-keyboard dragging still needs a real iPad check: the simulator automation could not activate floating mode. Docked keyboard, dismissal, and search layout regressions were checked natively.

@tiensonqin
tiensonqin merged commit f79b9bb into main Oct 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant