Repository navigation
Synchronize search dismissal with native iOS transitions - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling iOS search currently combines the system search/keyboard transition with a second full-screen modal dismissal. The outgoing toolbar can move or flash during teardown, and the capture bar is recreated afterward.
Present search beside the retained app navigation, with the underlying page and capture bar kept ready by the shared OCaml view. Synchronize the outgoing fade and teardown with UISearchController's native will/did-dismiss callbacks. The observer forwards SwiftUI's existing optional delegate methods and restores the original delegate on teardown. Keep the query/results intact until search has closed, and preserve destination navigation bars and overflow menus.
Validation:
ocaml-base-compiler.5.5.2(job log).Before and Apple TestFlight reference use the reporter's device recordings; after uses an iOS 26 simulator. Recordings and diagnostic logs are not included in the commit.
Before / after / Apple TestFlight comparison
before-after-apple-comparison.mp4
After: empty and populated queries
after-empty-and-results.mp4