Repository navigation
fix(mygo): align retained menu row slots - #291
Open
tiensonqin wants to merge 5 commits into
Open
tiensonqin wants to merge 5 commits into
tiensonqin wants to merge 5 commits into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix retained MyGo menu row composition at the menu boundary: nonempty labels grow, canonical
tooltip-keysrender in a visible trailing slot, checks follow Web placement and conditional gutter semantics, and typed dropdown owners receive a chevron. Empty owned labels add no spacer; custom child content remains mounted while closed dropdown panels remain lazy.docs/api-migrations.mdrecords the default rendering changes and concrete downstream migration. Generic buttons, mutation validation, schema admission, wire vocabulary, dependency pins, and application-owned menu styling are unchanged. Native OS menus retain their OS-controlled presentation.Validation
GOWORK=off.43c83de431ecusing a temporary modfile: tests, vet and build exit 0; committed pins unchanged.opam exec -- dune build @web platform/native/and coredune runtest test/: exit 0.npm run check: exit 0 (156 tests); tooling/schema tests: exit 0 (24 tests).1f44501ebecause the canonical shortcut is absent, passes after the fix, then deleted; no tests retained or existing assertions changed.v0.0.0-20261029151342-ba39a5080a18resolves through proxy.golang.org and sum.golang.org. Its extracted Go module builds, passes production-tag vet and existing menu tests: exit 0.Additional native SDL runtime suite: exit 1 because this machine has SDL 2.0.20 and cannot resolve
SDL_RenderGetWindow. Native compilation passed; this is not an all-native-tests-passed claim.Full tests run from the extracted Go submodule exit 1: the existing
TestAllSupportedKindsRenderexpects../../schema/mygo-manifest.jsonfrom the complete repository, outside that submodule. The complete repository's tests pass; no test assertions or manifest lookup behavior were changed.Real production Web/native visual qualification is pending. Start from matched menus containing an owned label, canonical shortcut, selected/unselected rows and empty-label custom content; compare slot alignment, remove the last selection/shortcut, then exercise true submenu open/close and dismissal. Application-specific spacing/background recipes must be validated in the consuming application; headless checks do not establish visual parity.
Link to Devin session: https://app.devin.ai/sessions/8fb8206975da46adad697ea4f962c885
Open in Devin Desktop: https://app.devin.ai/desktop/session/8fb8206975da46adad697ea4f962c885?variant=devin
Requested by: @tiensonqin