Repository navigation
fix: read pending application model reductions - #288
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lui_app.model appnow readsSignal.state_pendingbefore the published model in both application drivers. Reentrant reducers can queue A → B → A before signal publication; imperative async context fences must see the accumulated revision rather than the previous published snapshot. The public signature and reactive batching remain unchanged; reading does not flush rendering or patches.A retained regression covers plain, extension-enabled, reloadable and reloadable-extension constructors: two queued reductions are immediately readable without emitting patches, and explicit flush preserves the result. The migration guide distinguishes authoritative reads from borrowed published view signals.
Validation:
dune build @all; 236 core tests; 10 schema/tooling tests; headlessdune runtestwithLD_LIBRARY_PATH=$HOME/.local/lib SDL_VIDEODRIVER=dummy. The default environment first hit an outdated SDL symbol and then unavailable OpenGL bindings; the headless run uses the existing tests' GL-unavailable path, not GL pixel validation. No GUI or application parity acceptance is claimed.Link to Devin session: https://app.devin.ai/sessions/4a14d15bc6d44d18a9254cd088d5cc5e
Open in Devin Desktop: https://app.devin.ai/desktop/session/4a14d15bc6d44d18a9254cd088d5cc5e?variant=devin
Requested by: @tiensonqin