Repository navigation
Fix startup sync refresh for empty journal pages - #141
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register journal pages even when their initial root read is empty. Previously these pages were missing from the runtime registry, so a page-tree-only sync invalidation did not refresh the initial feed. An older scan still loading history could then publish empty Today over the synchronized content.
Registration makes that invalidation start a new initial feed, reusing the existing feed-session fencing to retire the old scan. No Capture, UI, protocol or public API changes.
Add one public-runtime regression: discover empty Today, hold its initial history continuation, synchronize three Today roots, then finish the old continuation before or after the refreshed feed. Both orderings must retain the synchronized roots without Capture.
Validation
[]instead of the three synchronized UUIDs before the production fix; all 184 runtime cases pass after it.dune build @all app/native_embed.exe.o— passed.dune runtest --force— passed (1,088 Alcotest cases across 21 suites).spec-dev-tool check --all— 297 valid documents; 5 pre-existing invalid documents, each byte-identical to the base revision. No decision documents changed.Current + No journal entriesfollowed by Capture recovery when existing blank roots received text. The fixed build automatically displayed the two edited roots in six cold-start runs without Capture. Public graph export later confirmed an additional blank root was retained; this was not a two-total-root graph.d135571d46abbd4c3c9b146e61874f5986170347; installed executable SHA-25615f2f51c2991a9ebfbbe20a50034f05c2f4fc56d159ff43c454614664c663778.cross_abi_validated=false), not real-device/cross-ABI acceptance. Public current-entity exports establish logical zero roots, not native database byte-level erasure. GUI runs do not establish internal response ordering or exclude every possible timing failure; controlled runtime regression covers the two response orderings.Link to Devin session: https://app.devin.ai/sessions/55da92d6550b4d348f51aff910621294
Open in Devin Desktop: https://app.devin.ai/desktop/session/55da92d6550b4d348f51aff910621294?variant=devin
Requested by: @RCmerci