Repository navigation
Recover stale journal date cursors without losing same-day pages - #140
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Journal writes can invalidate an in-flight timeline date continuation. Recover the current
Root_datesscan with at most two cursorless reads, resuming inclusively at its oldest observed date. Deduplicate already observed UUIDs on that boundary date without dropping unseen same-day pages. Preserve the loaded prefix, remaining root quota, generation ownership and strict Overlay cursor validation.Add one public
Production_runtimeregression covering replay, same-day UUIDs, retry exhaustion and superseded scans, with red/green verification.Validation
dune build @all app/native_embed.exe.o,dune runtest --force, andgit diff --checkpassed onffd787c839aa9ae9645d0f2aada097b94fc1d8b6.ocaml-sync-testgraph: baseline/control captures reproducedstaleReadCursor / listTimelineDatesin 3/3 attempts; patched captures did not reproduce it in 3 attempts. Final two cycles verified immediate post-capture/append state, task status, refresh/history and restart persistence. All four exact test-owned subtrees were cleaned up; final App diagnostics Current/Ready/Open, zero outbox.spec-dev-toolandocamlformatunavailable in the prepared environment; those checks are not claimed.cross_abi_validated=false; no physical-device, macOS or independent server-readback claim.Unresolved observation
The first patched run recorded a separate
invalidRequest / graphRequest / admissionwithout a request ID. It did not recur in one header-only control or the final two patched cycles. Neither its cause nor its resolution is established; this PR does not claim to fix it or establish an all-green product result.Final Simulator evidence
Link to Devin session: https://app.devin.ai/sessions/ebe2c4b314574e34af37fb03fa521c1a
Open in Devin Desktop: https://app.devin.ai/desktop/session/ebe2c4b314574e34af37fb03fa521c1a?variant=devin
Requested by: @RCmerci