Repository navigation
Separate account recovery from native navigation chrome - #139
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
Journalsfrom overlapping the account recovery prompt after Sign out → dismiss authentication → Sign in again → Close. Allocate the recovery view above the runtime/navigation host in one stable zero-spacingVStack, instead of applying an outer top safe-area inset. Preserve the single runtime host, recovery actions and authentication sheet lifecycle.Validation
Final source:
a7548a01a60f11a2a648eca44f3956becde76354, based on9488d3c.dune build @all app/native_embed.exe.oanddune runtest --force: passed in the locked OCaml 5.5.0 environment. The initial unrelated WebSocket liveness timing failure passed on the full rerun.cross_abi_validated=false; no device/ABI or macOS acceptance claim.spec-dev-toolis unavailable; no decision documents changed.9488d3c)a7548a0)Link to Devin session: https://app.devin.ai/sessions/ebe2c4b314574e34af37fb03fa521c1a
Open in Devin Desktop: https://app.devin.ai/desktop/session/ebe2c4b314574e34af37fb03fa521c1a?variant=devin
Requested by: @RCmerci