This repository was archived by the owner on Jan 20, 2020. It is now read-only.
Consumed calculation fix and bug fix when decreases depleted.#4
Open
mlilius wants to merge 4 commits intolog-just:masterfrom
Open
Consumed calculation fix and bug fix when decreases depleted.#4mlilius wants to merge 4 commits intolog-just:masterfrom
mlilius wants to merge 4 commits intolog-just:masterfrom
Conversation
…here (http://docs.aws.amazon.com/AmazonCloudWatch/latest/DeveloperGuide/dynamo-metricscollected.html) you should use the sum and divide to get the number per second.
…aining decreases.
Author
|
I added a maximum read/write setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a couple of problems when trying to use this. First the consumed calculations were not correct. They need to be sum and then divided by the number of seconds in the time window to get consumed/second.
I also found that if you run out of available decreases it would no longer allow increases.
BTW, thank you for this. It is exactly what I was looking for. Nice clean code too.