fix: expose iOS footer accessibility elements#700
Merged
lodev09 merged 3 commits intoMay 30, 2026
Conversation
|
@erickreutz is attempting to deploy a commit to the lodev09 Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lodev09
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes iOS footer accessibility traversal for nested footer controls by exposing footer child accessibility elements through the sheet container, recalculating the sheet accessibility container after footer layout changes, and restoring the previous window accessibility elements when the sheet dismisses.
This builds on #699 for cases where footer controls need to remain reachable by XCTest and assistive technologies while the sheet is presented.
Type of Change
Test Plan
Ran
PATH="$(dirname "$(xcrun --find clang-format)"):$PATH" scripts/objclint.sh.Ran
git diff --check.Validated the equivalent patch in Lugg iOS app E2E coverage.
Screenshots / Videos
N/A
Checklist