Replace the local snapshot extension .zip to .snapshot#304
Conversation
anisaoshafi
requested review from
carole-lavillonniere and
silv-io
as code owners
gtsiolis
left a comment
gtsiolis
left a comment
There was a problem hiding this comment.
Left some comments below we discuss async or sync!
|
|
||
| const ( | ||
| snapshotExt = ".snapshot" // user-facing extension for local snapshots | ||
| legacySnapshotExt = ".zip" // accepted on load for backward compatibility |
There was a problem hiding this comment.
praise: Thanks for adding this! 🙏
| lstk snapshot load my-baseline # loads ./my-baseline or ./my-baseline.zip | ||
| lstk snapshot load ./checkpoint.zip # loads from explicit path | ||
| lstk snapshot load pod:my-baseline # loads from LocalStack Cloud | ||
| lstk snapshot load my-baseline # loads ./my-baseline or ./my-baseline.snapshot |
There was a problem hiding this comment.
question: Couldn't find a better line to add this comment, but loading an invalid file returns an error. Could we update that and possibly remove the file extension reference?
There was a problem hiding this comment.
Good catch, will change 🙏🏼
There was a problem hiding this comment.
fyi, this error was returned from emulator in this line, we only prefix it with load failed for service:.
I modified it to look like this. let me know if it needs more tweaking. thank you!
There was a problem hiding this comment.
Perfect, this matches the error pattern and style we introduced for other cases, too. 💯
anisaoshafi
force-pushed
the
devx-848-replace-snapshot-file-extension
branch
2 times, most recently
from
f297e58 to
75a6d5b
Compare
anisaoshafi
force-pushed
the
devx-848-replace-snapshot-file-extension
branch
from
75a6d5b to
2037aa1
Compare
3 participants
Use
.snapshotextension for saving snapshots locally.cc @gtsiolis