-
Notifications
You must be signed in to change notification settings - Fork 13
Rename aws-replicator extension to aws-proxy #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64807e6 to
8b49a05
Compare
nik-localstack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
| from aws_replicator.config import HANDLER_PATH_PROXIES, HANDLER_PATH_REPLICATE | ||
| from aws_replicator.server import ui as web_ui | ||
| from aws_replicator.server.aws_request_forwarder import AwsProxyHandler | ||
| from aws_replicator.shared.models import AddProxyRequest, ReplicateStateRequest, ResourceReplicator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We could remove the ResourceReplicator interface entirely now that it's not used (from aws_replicator.shared.models)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks - was able to do a few more cleanups in models and surrounding modules. 👍
Co-authored-by: Nikos <nikos.michas@localstack.cloud>
Motivation
This PR is a step towards renaming the
aws-replicatorextension to the more fitting nameaws-proxy, to avoid confusion with the AWS Replicator.When this project was first developed as an experimental extension, the scope was a bit convoluted, and it tried to address different aspects of enabling hybrid scenarios with LocalStack, including the "replicator" aspect, as well as the "proxy" aspect. The Replicator has graduated in the meantime and is now available as a proper feature in upstream LocalStack (Pro), 🚀 whereas the focus of this extension has been reduced to the Proxy aspect - hence the renaming here.
/cc @nik-localstack Adding you as reviewer since you've recently helped make some changes in this extension. :)
Changes
localstack-extension-aws-replicatortolocalstack-extension-aws-proxyaws_replicatortoaws_proxy0.2.0for this new extensionTODOs: