Migrate CI setup from API keys to auth tokens #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
force-pushed
the
auth-token-setup
branch
4 times, most recently
from
4a3981a to
b6e9d7e
Compare
whummer
force-pushed
the
auth-token-setup
branch
from
b6e9d7e to
464d9b4
Compare
whummer
commented
Sep 9, 2025
| @pytest.mark.parametrize( | ||
| "metadata_gzip", | ||
| [ | ||
| # True, TODO re-enable once the logic is fixed |
Member
Author
There was a problem hiding this comment.
FYI - disabling this test temporarily for now, to be fixed soon in a follow-up iteration. 👍
nikosnm
approved these changes
Sep 10, 2025
nik-localstack
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate CI setup from API keys to auth tokens. A corresponding
LOCALSTACK_AUTH_TOKENsecret has been configured in the repo settings (and the oldLOCALSTACK_API_KEYsecret has been deleted).We're still seeing some
BadDigestresults in the tests, which could be related to recent changes inbotocore. The test output shows a diff for theDisplayNameentry in the S3 response, so potentially there's some issue there.. One of the tests has been disabled for now - to be fixed soon in a follow-up iteration.