smite-scenarios: add support for suppressing known violations - #202
Open
NishantBansal2003 wants to merge 3 commits into
Open
smite-scenarios: add support for suppressing known violations#202NishantBansal2003 wants to merge 3 commits into
NishantBansal2003 wants to merge 3 commits into
Conversation
Targets can now declare known violations that should be suppressed until they are fixed upstream. IR scenario will check if a violation is in the known list and skip the failure if so, logging it as debug instead. This provides the foundation for handling multiple oracles as they're added in the future, establishing the standard process for suppressing known violations until upstream fixes land. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
CLN currently allows `funding_satoshis` values exceeding total Bitcoin supply during `open_channel` and `accept_channel` negotiation. These values should be rejected early as they cannot result in a valid channel. This is tracked upstream and will be suppressed until fixed. see: ElementsProject/lightning#9368 Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
LND allows `open_channel` with an omitted `channel_type`, violating BOLT 2 even though it signals the required `option_channel_type` feature bit. This will be tracked upstream and will be suppressed until fixed. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets can now declare known violations that should be
suppressed until they are fixed upstream. IR scenario will
check if a violation is in the known list and skip the failure
if so, logging it as debug instead. This provides the foundation
for handling multiple oracles as they're added in the future,
establishing the standard process for suppressing known violations
until upstream fixes land.
Currently known violations that are suppressed are:
CLN currently allows
funding_satoshisvalues exceedingtotal Bitcoin supply during
open_channelandaccept_channelnegotiation. These values should be rejected early as they cannot
result in a valid channel. This is tracked upstream and will be
suppressed until fixed.
LND allows
open_channelwith an omittedchannel_type,violating BOLT 2 even though it signals the required
option_channel_typefeature bit. This will be trackedupstream and will be suppressed until fixed.