Cbuffer tests for MatrixSingleSubscriptExpr#753
Merged
Conversation
farzonl
added
the
test-all
Member
Author
|
This test does not include Swizzle of MatrixSingleSubscriptExpr that is coming in a later pr. |
bogner
reviewed
Feb 18, 2026
| Buffers: | ||
| - Name: cbuffer | ||
| Format: Float32 | ||
| Data: [ 1.1, 0xFFFF, 0xFFFF, 0xFFFF, |
Contributor
There was a problem hiding this comment.
0xFFFF isn't a great sigil value for float IMO (It's like 9.18e-41?). I guess you were going for an all 1s NaN and missed a few digits. That's fine, alternatively a weird bit pattern like 0x5a5a5a5a is just a number but it's usually fairly easy to spot.
Icohedron
requested changes
Feb 18, 2026
Icohedron
approved these changes
Mar 3, 2026
- Add Vulkan Clang Xfails (Vulkan doesn't know how to legalize arrays of vectors)
…ail for amd because it is failing on newer gpus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #747
This change tests Matrix padding is correct and applies to SingleSubscripting.