Open
Conversation
This reverts commit 5c96762.
s-perron
reviewed
Feb 20, 2026
Contributor
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
it is hard to look at the results and know that they are correct. I need to look at an entry in OUT_DTID and make sure it is at the correct index. I then need to go to OUT_GTID and determine the correct value for the DTID in the first array. Then I need to go to a third.
It would be nice to have all of the related information together with appropriate comments to explain the results.
| RWStructuredBuffer<uint> OUT_GI : register(u2); | ||
|
|
||
| [numthreads(2, 2, 2)] | ||
| void main(uint3 DTID : SV_DispatchThreadID, uint3 GID : SV_GroupID, uint3 GTID : SV_GroupThreadID, uint GI : SV_GroupIndex) { |
Comment on lines
+2
to
+3
| RWStructuredBuffer<uint> OUT_DTID : register(u0); | ||
| RWStructuredBuffer<uint> OUT_GTID : register(u1); |
Contributor
There was a problem hiding this comment.
Add a comment explaining why you don't simply use uint3. I assume it is because we currently get the alignment wrong.
| # RUN: %dxc_target -T cs_6_0 -Fo %t.o %t/system_values.hlsl | ||
| # RUN: %offloader %t/system_values.yaml %t.o | ||
|
|
||
| # Metal is reporting DispatchThreadID value ot 8 for the x dimension. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Metal is reporting DispatchThreadID value ot 8 for the x dimension. | |
| # Metal is reporting DispatchThreadID value of 8 for the x dimension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testing for compute shader system semantics on a 2x2x2 dispatch.