Conversation
Collaborator
Author
|
Separate PR to fix up the new MPI TAP test as discussed in #587 |
adammoody
force-pushed
the
mpitests
branch
2 times, most recently
from
e251b0a to
4f65e49
Compare
adammoody
commented
Dec 14, 2020
Comment on lines
+16
to
+26
| #define all_ok(condition, comm, ...) \ | ||
| do { \ | ||
| int input = (int) condition; \ | ||
| int output; \ | ||
| MPI_Allreduce(&input, &output, 1, MPI_INT, MPI_LAND, comm); \ | ||
| int rank; \ | ||
| MPI_Comm_rank(comm, &rank); \ | ||
| if (rank == 0) { \ | ||
| ok_at_loc(__FILE__, __LINE__, output, __VA_ARGS__, NULL); \ | ||
| } \ | ||
| } while (0) |
Collaborator
Author
There was a problem hiding this comment.
@CamStan , we can eventually move this kind of macro to an mpitap.h file. I haven't tested this just yet, but it at least compiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding first TAP-based test case using multiple MPI ranks.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: