Skip to content

Prevent resource manager from being created by empty managed arrays#357

Merged
adayton1 merged 5 commits intodevelopfrom
delayRM
Mar 3, 2026
Merged

Prevent resource manager from being created by empty managed arrays#357
adayton1 merged 5 commits intodevelopfrom
delayRM

Conversation

@liu15
Copy link
Copy Markdown
Collaborator

@liu15 liu15 commented Feb 25, 2026

This prevents pre-main cuda calls for global static Managed Arrays.

@liu15 liu15 requested review from adayton1 and robinson96 February 25, 2026 22:03
@liu15
Copy link
Copy Markdown
Collaborator Author

liu15 commented Feb 25, 2026

There is a bug here somewhere. I am investigating.

@liu15
Copy link
Copy Markdown
Collaborator Author

liu15 commented Feb 25, 2026

There is a bug here somewhere. I am investigating.

NVM, I think I am hitting existing stale data issues from gpu_sim mode. I don't think I will be able to test this properly until those are fixed.

Comment thread src/chai/ManagedArray.inl
Comment thread src/chai/ManagedArray.inl
Copy link
Copy Markdown
Contributor

@robinson96 robinson96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 merged commit 90ee6f0 into develop Mar 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants