lkl: tests: minor fn parameter and kasan parsing changes#610
Conversation
The existing t.fn(t->arg1, t->arg2, t->arg3) call can lead to build
failures:
tests/test.c: In function ‘lkl_test_run’:
tests/test.c:93:23: error: too many arguments to function ‘t->fn’;
expected 0, have 3
The parameters don't appear to be used, so can be removed.
Signed-off-by: David Disseldorp <ddiss@suse.de>
CONFIG_KASAN_KUNIT_TEST is a kernel specific build option, so expose it via the arch config.h instead of the tools-generated lkl_autoconf.h. Both LKL_HOST_CONFIG_KASAN and LKL_HOST_CONFIG_KASAN_KUNIT_TEST are now unused so can be removed. Signed-off-by: David Disseldorp <ddiss@suse.de>
Grep for the kunit kasan group summary so that we can log the test + fail count. Use a common exit path to ensure log is always freed. Signed-off-by: David Disseldorp <ddiss@suse.de>
|
regarding |
The change in |
HOST_CALL() uses a (*host_##name)() function pointer while callers
provide regular syscall parameters. With gcc -std=gnu23 this results in:
lib/hijack/hijack.c: In function ‘hijack_setsockopt’:
lib/hijack/hijack.c:176:24: error: too many arguments to function ‘host_setsockopt’; expected 0, have 5
176 | return host_setsockopt(fd, level, optname, optval, optlen);
| ^~~~~~~~~~~~~~~ ~~
Signed-off-by: David Disseldorp <ddiss@suse.de>
|
v2:
checkpatch failure is due to inclusion of raw compiler output (lines exceeding 72 chars) in commit message. IMO it can be ignored. |
|
Thanks @ddiss, sorry for the merge delay! |
Uh oh!
There was an error while loading. Please reload this page.