Remove zero width space when getting text range for comment highlights#596
Merged
Remove zero width space when getting text range for comment highlights#596
Conversation
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
2 times, most recently
from
b0097a8 to
a6f34d6
Compare
ajwild
commented
Apr 20, 2025
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
a6f34d6 to
e287f0d
Compare
ajwild
commented
Jun 4, 2025
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
e287f0d to
73e32e4
Compare
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
73e32e4 to
5a5d397
Compare
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
142ef7f to
cce8a09
Compare
ajwild
force-pushed
the
zero-width-space-text-ranges
branch
from
cce8a09 to
4c84521
Compare
marcbachmann
approved these changes
Mar 20, 2026
Member
|
💥 /backport release-2026-03 The backport to release-2026-03 failed. Error: Command failed: /usr/bin/git fetch origin release-2026-03 4c845214a8ff157270e50d5a12d2095f3a579ecc master
fatal: couldn't find remote ref release-2026-03
at genericNodeError (node:internal/errors:985:15)
at wrappedFn (node:internal/errors:539:14)
at ChildProcess.exithandler (node:child_process:417:12)
at ChildProcess.emit (node:events:508:28)
at ChildProcess.emit (node:domain:489:12)
at maybeClose (node:internal/child_process:1101:16)
at Socket.<anonymous> (node:internal/child_process:457:11)
at Socket.emit (node:events:508:28)
at Socket.emit (node:domain:489:12)
at Pipe.<anonymous> (node:net:346:12) |
Collaborator
|
🎉 This PR is included in version 5.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relations:
Motivation
When creating comments in Livingdocs it uses the selected text to create a highlight. If the text selection contains a zero width non-breaking space, which is removed when the component is blurred, then the highlight never computes the correct start and end offset for the range because the text string no longer matches.
Changelog