Wrap provider errors with HTTP status code#30
Open
biglittlebigben wants to merge 4 commits into
Open
Conversation
2 tasks
paulwe
approved these changes
Jun 17, 2026
boks1971
approved these changes
Jun 17, 2026
milos-lk
reviewed
Jun 17, 2026
| return fmt.Sprintf("Err: %s, Status Code: %d", e.Err, e.StatusCode) | ||
| } | ||
|
|
||
| func (e *ErrorWithStatusCode) UnWrap() error { |
There was a problem hiding this comment.
maybe we could add assertion on the wrapped error in tests as well
milos-lk
reviewed
Jun 17, 2026
| @@ -0,0 +1,18 @@ | |||
| package storage | |||
milos-lk
reviewed
Jun 17, 2026
| } | ||
|
|
||
| func (e *ErrorWithStatusCode) Error() string { | ||
| return fmt.Sprintf("Err: %s, Status Code: %d", e.Err, e.StatusCode) |
There was a problem hiding this comment.
nit: error stings are usually not capitalized
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
milos-lk
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorWithStatusCodetype so callers can extract HTTP status codes viaerrors.Asregardless of the storage backend.Motivation
Enables better metrics on upload/download failures by surfacing the HTTP status code in a backend-agnostic way — in particular, distinguishing user errors (4xx: bad credentials, missing object, access denied) from infrastructure issues (5xx, network errors that pass through unwrapped).
Test plan
go test ./...