feat(agents): implement cross-region deployment confirmation - #938
Open
rektdeckard wants to merge 4 commits into
Open
feat(agents): implement cross-region deployment confirmation#938rektdeckard wants to merge 4 commits into
rektdeckard wants to merge 4 commits into
Conversation
rektdeckard
requested review from
a team,
real-danm,
varunkhurana96 and
yoonsio
August 13, 2026 22:50
real-danm
approved these changes
Aug 14, 2026
real-danm
left a comment
real-danm
left a comment
Contributor
There was a problem hiding this comment.
is this a breaking change with the current flow? if it is release will need to be major version bump which would need to be reflected in the server-sdk-go as well.
Clients will need to update before they see this message, i think we can enforce this on the config side for the min cli version. that's for a future PR
Member
Author
|
The change is backwards-compatible, we fall back to the default flow if the new client settings fields are not present. Added some tests to verify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/livekit/issue/DEVX-636/warn-in-cli-when-eu-agent-deploy-uses-us-observability-region
Show warning and require additional confirmation when non-EU project elects to deploy an agent to an EU cluster.
CleanShot.2026-08-13.at.18.04.06.mp4
RELATED: https://github.com/livekit/cloud-agents/pull/780