-
Notifications
You must be signed in to change notification settings - Fork 146
feat(agent): Node.js agent support for lk agent dev/start/console #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
u9g
merged 6 commits into
brian/agent-session-node-support
from
jason/agent-console-dev-node
Jun 11, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9128955
feat(agent): support Node.js agents in lk agent dev/start/console
u9g 2430a24
feat(agent): load discovered .env files into Node agents via --env-file
u9g 7660aa2
feat(console): fail fast when the agent job crashes before connecting
u9g 3d21399
Revert "feat(agent): load discovered .env files into Node agents via …
u9g 22f0e97
feat(agent): forward runtime args after -- to node/python
u9g 5dbee0e
test(agent): trim agent run tests to the fail-signal case
u9g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright 2026 LiveKit, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "os" | ||
| "os/exec" | ||
| "path/filepath" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/livekit/livekit-cli/v2/pkg/agentfs" | ||
| ) | ||
|
|
||
| func TestAgentProcessFailSignal(t *testing.T) { | ||
| if _, err := exec.LookPath("node"); err != nil { | ||
| t.Skip("node not on PATH") | ||
| } | ||
|
|
||
| // An agent whose job crashes logs a marker but keeps the process alive; | ||
| // Failed() must fire without waiting for exit. | ||
| dir := t.TempDir() | ||
| script := `console.log('shutting down job task {"reason": "job crashed"}'); setTimeout(() => {}, 30000);` | ||
| require.NoError(t, os.WriteFile(filepath.Join(dir, "agent.js"), []byte(script), 0o644)) | ||
|
|
||
| ap, err := startAgent(AgentStartConfig{ | ||
| Dir: dir, | ||
| Entrypoint: "agent.js", | ||
| ProjectType: agentfs.ProjectTypeNode, | ||
| FailSignals: consoleCrashSignals, | ||
| }) | ||
| require.NoError(t, err) | ||
| defer ap.Kill() | ||
|
|
||
| select { | ||
| case <-ap.Failed(): | ||
| case <-time.After(10 * time.Second): | ||
| t.Fatal("Failed() did not fire on crash marker") | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot of tests aren't super useful here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just cleaned up the tests.