Add check to make sure newly compiled dts versions work in downstream projects with older typescript versions#1761
Draft
Add check to make sure newly compiled dts versions work in downstream projects with older typescript versions#1761
Conversation
…e works when compiled against old typescript versions More context can be found here: #1668 (review)
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs a check to make sure that a given version of livekit-client can be used in a downstream project which is configured with an older version typescript.
In theory,
downlevel-dtsshould handle this, but there has been at least one breaking typing change in the past whichdownlevel-dtshas been unable to patch over (more info: #1668) so this serves as a mechanism to catch cases like this in the future before they are reported by users.