change liblivekit to dll and link protobuf statically #37
+153
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that our liblivekit_ffi.dylib or livekit_ffi.a contains some protobuf symbols, it is likely linked to the binary by our rust livekit ffi
if shipping a static liblivekit.a, it will require the same protobuf version when linking it to the apps. which will make it impossible to use by our developers
if shipping a dynamic liblivekit.dll or dylib, we will need to link the protobuf statically to the dynamic lib so that developers do not need to worry about the protobuf
This PR fixed the problem by shipping a dynamic liblivekit dylib, and link the protobuf statically to the dynamic lib