fix(ivr): reimplement TfidfLoopDetector with numpy to remove scikit-learn dependency - #6867
Open
Mugunth007 wants to merge 1 commit into
Open
fix(ivr): reimplement TfidfLoopDetector with numpy to remove scikit-learn dependency#6867Mugunth007 wants to merge 1 commit into
Mugunth007 wants to merge 1 commit into
Conversation
…earn dependency Fixes livekit#6778. Replaces sklearn TfidfVectorizer and cosine_similarity with a pure numpy TF-IDF calculation. This resolves silent loop detection failures on installations where scikit-learn is not installed.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6778.
Summary
TfidfLoopDetectorpreviously relied onscikit-learn, which was not declared as a dependency or extra inpyproject.toml. On standard installations withoutscikit-learn,check_loop_detection()silently returnedFalseand disabled loop detection.Changes
sklearn.feature_extraction.text.TfidfVectorizerandsklearn.metrics.pairwise.cosine_similaritywith a purenumpyimplementation.TfidfVectorizerdefaults (token_pattern=r"(?u)\b\w\w+\b", smooth IDF formulaln((1 + N) / (1 + df)) + 1, and L2 normalization).test_tfidf_loop_detector_without_sklearnintests/test_ivr_activity.pyto ensure loop detection works independent ofscikit-learn.Testing
uv run pytest tests/test_ivr_activity.py(6/6 passed)uv run ruff check&uv run ruff formatpassed